should SLIP support be removed?

Andy Green andy at warmcat.com
Thu May 18 15:22:01 UTC 2006


Robert P. J. Day wrote:

> well, since you claim that SLIP works for you, why don't you remove
> that undef and see what happens after that?  without looking too
> closely at the code, maybe it will fix some of those aesthetic issues
> for you.  one can always dream.

busybox-1.1.2/networking/interface.c:1516: error: 'slip_hwtype' 
undeclared here (not in a function)
busybox-1.1.2/networking/interface.c:1517: error: 'cslip_hwtype' 
undeclared here (not in a function)
busybox-1.1.2/networking/interface.c:1518: error: 'slip6_hwtype' 
undeclared here (not in a function)
busybox-1.1.2/networking/interface.c:1519: error: 'cslip6_hwtype' 
undeclared here (not in a function)
busybox-1.1.2/networking/interface.c:1520: error: 'adaptive_hwtype' 
undeclared here (not in a function)

$ grep slip_hwtype * -R
networking/interface.c: &slip_hwtype,
networking/interface.c: &cslip_hwtype,
networking/interface.c: slip_hwtype.title = _("Serial Line IP");
networking/interface.c: cslip_hwtype.title = _("VJ Serial Line IP");

Looks like you might as well optimize HWSLIP stuff out.

SLIP works fine without it with net-tools slattach and busybox ifconfig.

-Andy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4492 bytes
Desc: S/MIME Cryptographic Signature
Url : http://lists.busybox.net/pipermail/busybox/attachments/20060518/c056f099/attachment.bin 


More information about the busybox mailing list