should SLIP support be removed?

[Robert P. J. Day]

On Thu, 18 May 2006, Robert P. J. Day wrote:

> On Thu, 18 May 2006, Andy Green wrote:
>
> > Robert P. J. Day wrote:
> > >   i ask only because of this snippet from networking/interface.c:
> > >
> > > #define HAVE_HWETHER    1
> > > #define HAVE_HWPPP      1
> > > #undef HAVE_HWSLIP		<--
> > >
> > > what exactly does that imply in terms of SLIP support?
> >
> > I'm actually using SLIP on a busybox, ifconfig seems to work okay
> > (there is a minor bug that both ends of the PTP link show the same
> > IP) with it, but slattach was needed externally from net-tools
> > package.  You can set the SLIP IPs and so on with busybox ifconfig
> > fine FWIW.
>
> fair enough.  so what does that "undef" represent?  just curious.

just to clarify what i'm asking here, what is the point of explicitly
undef'fing HWSLIP early on in networking/interface.c, only to check
for its definition later on:

...
#ifdef HAVE_HWSLIP
#include <net/if_slip.h>
#endif
...
#ifdef HAVE_HWSLIP
        if (ife->type == ARPHRD_SLIP || ife->type == ARPHRD_CSLIP ||
...
#if HAVE_HWSLIP
        &slip_hwtype,
        &cslip_hwtype,
        &slip6_hwtype,
        &cslip6_hwtype,
        &adaptive_hwtype,
#endif
...

and so on.

rday