[patch] fix warning in ipaddress.c

Jason Schoon floydpink at gmail.com
Wed May 17 14:52:38 UTC 2006


On 5/17/06, Bernhard Fischer <rep.nop at aon.at> wrote:
>
> On Wed, May 17, 2006 at 01:07:20PM +0200, Bernhard Fischer wrote:
> >On Wed, May 17, 2006 at 12:25:14PM +0200, walter harms wrote:
>
> >>>>hi list,
> >>>>this patch fixes:
> >>>>In function `ipaddr_list_or_flush':
> >>>>warning: declaration of `round' shadows a global declaration
> >>>>
> >>>>and removes an '#if 0' statement
> >>>>
> >>>>re,
> >>>>  wh
>
> >
> >I'm a little bit irritated by your change..
> >If i read this right, then you rename an unused variable instead of
> >removing it. Why aren't you removing it completely?
> >
> >Please clarify.
> >TIA,
> >Bernhard
>
> To outline what i mean, what's the value of printing that error (i
> really do not know)?
>
> What about the attached untested snippet?


Given that the error message was in an #if 0, there obviously was no value.
The remove patch seems correct to me.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.busybox.net/pipermail/busybox/attachments/20060517/bdd8f857/attachment-0002.htm 


More information about the busybox mailing list