tar -p and usernames vs. uid's

[Denis Vlasenko]

On Sunday 07 May 2006 07:03, Rob Landley wrote:
> On Saturday 06 May 2006 9:13 am, Denis Vlasenko wrote:
> > On Friday 05 May 2006 23:08, Rob Landley wrote:
> > > On Thursday 04 May 2006 6:56 pm, Natanael Copa wrote:
> > > > Could anybody please take a short look at the previously posted update
> > > > for the tar uname/gname patch and get it committed?
> > > >
> > > > http://www.busybox.net/lists/busybox/2006-April/020789.html
> > >
> > > Sorry, this got blocked because my copy of tar is hacked up with a
> > > modified version of Dennis Vlasenko's write coalesce fix, which is A)
> > > much simpler, B) doesn't work.  I've been meaning to track down why. 
> > > (I'm getting the padding sizes wrong somewhere...)
> >
> > Just built with write coalesce fix, and tarred up the build tree:
> >
> > # ./busybox tar cf - . | md5sum
> > ca14e9cb6d9bb580b736ee6f04a1ae8a  -
> >
> > # ../busybox.org/busybox tar cf - . | md5sum
> > ca14e9cb6d9bb580b736ee6f04a1ae8a  -
> >
> > Looks like there is no difference.
> >
> > Please send me a testcase which fails for you.
> 
> No, I mean the fix I applied to my tree is simpler than your fix, but I seem 
> to have screwed it up.  (Haven't had time to look at it today, it's attached 
> though...)

Maybe here

+               readSize = TAR_BLOCK_SIZE - (readSize & TAR_BLOCK_SIZE);

You need (readSize & (TAR_BLOCK_SIZE-1))
--
vda