[PATCH] replace findstring with filter

Robert P. J. Day rpjday at mindspring.com
Mon May 15 09:05:41 UTC 2006


On Mon, 15 May 2006, Bernhard Fischer wrote:

> On Fri, May 12, 2006 at 04:47:35PM -0400, Rob Landley wrote:
> >On Friday 12 May 2006 8:39 am, Robert P. J. Day wrote:
> >>   technically, filter is safer here since it matches based on entire
> >> words whereas findstring might match substrings (unlikely to actually
> >> cause a problem but why live dangerously?)
> >>
> >> rday
> >
> >I'll leave this one up to Bernhard...
>
> Well, it's extremely unlikely to run into matching the wrong stuff,
> since we match against the *full path* including the extension of
> the file, as you note.
>
> While your change would be technically correct (I'm not really
> opposed to it, i honestly think that it makes no difference
> whatsoever since we are unlikely to introduce source with
> this.c.that this.c.there etc), it is incomplete. If you provide a
> patch which adjusts these in the whole tree (not just in libbb),
> then it's ok to be checked in.

i realize it's a piddling change but i did notice that it seems to be
the standard practise for people who write lots of makefiles -- those
people will immediately know what you're doing when they see "filter".
if i get a few minutes today, i'll whip up a patch that handles them
all.

rday

p.s.  your point is well-taken that mis-matching against a *full path*
is unlikely but, in the future, if "vpath" is incorporated somehow,
that mis-matching will suddenly become at least a little more likely
if you keep using "findstring".  just trying to avoid even *potential*
future problems. :-)



More information about the busybox mailing list