svn commit: trunk/busybox/testsuite

Rob Landley rob at landley.net
Fri May 5 22:24:54 UTC 2006


On Friday 05 May 2006 5:44 pm, Bernhard Fischer wrote:
> This readlink.tests isn't executable..

It is on my system.  I ran it to make sure it worked ok before checking it in.  
(The rm -r $VARIABLE in it scares me, by the way, but not quite enough to 
rewrite it to make that go away.)

Is there an svn chmod?  (svn info doesn't say, svn proplist doesn't say...)  
If svn is really that stupid, I'll happily add a "chmod -R +x 
testsuite/*.tests" to the makefile.

> Should we 
> PATH="$LINKSDIR":$srcdir:$bindir:$PATH \
> 	$SHELL "${srcdir:-.}/$applet".tests
>
> or rely on the .tests to be +x ?

The second.  All the rest of them are, and I'm not changing the testsuite to 
humor a broken tool.  (Change the makefile, yes...)

> Also there is this line missing here:
>
> optional FEATURE_READLINK_FOLLOW
>
> >+testing "readlink -f on a file" "readlink -f ./$TESTFILE"
> > "$PWD/$TESTFILE\n" "" "" +testing "readlink -f on a link" "readlink -f
> > ./$TESTLINK" "$PWD/$TESTFILE\n" "" "" +testing "readlink -f on an invalid
> > link" "readlink -f ./$FAILLINK" "" "" "" +testing "readlink -f on a wierd
> > dir" "readlink -f $TESTDIR/../$TESTFILE" "$PWD/$TESTFILE\n" "" "" +
> >+
> >+# clean up
> >+rm -r "$TESTLINK" "$TESTDIR"
> >+

I'm assuming the line without the + is the one you want to add, and the ones 
with the + are already there, which confused me for several seconds...

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list