svn commit: trunk/busybox: coreutils include

Bernhard Fischer rep.nop at aon.at
Fri May 5 08:24:00 UTC 2006


On Fri, May 05, 2006 at 09:17:47AM +0200, Bernhard Fischer wrote:
>On Tue, Apr 25, 2006 at 03:40:56PM -0700, landley at busybox.net wrote:
>>Author: landley
>>Date: 2006-04-25 15:40:53 -0700 (Tue, 25 Apr 2006)
>>New Revision: 14942
>>
>>Log:
>>Convert a chunk of usage.h to USE_ and SKIP_ (more to do there), and fix a
>>DEFALT typo in du while I was there.
>>
>>
>>Modified:
>>   trunk/busybox/coreutils/Config.in
>[]
>>Changeset:
>>Modified: trunk/busybox/coreutils/Config.in
>>===================================================================
>>--- trunk/busybox/coreutils/Config.in	2006-04-25 18:42:23 UTC (rev 14941)
>>+++ trunk/busybox/coreutils/Config.in	2006-04-25 22:40:53 UTC (rev 14942)
>>@@ -26,6 +26,13 @@
>> 	  cat is used to concatenate files and print them to the standard
>> 	  output.  Enable this option if you wish to enable the 'cat' utility.
>> 
>>+config CONFIG_FEATURE_CAT_ESCAPE
>>+	bool "support -vetET"
>>+	depends on CONFIG_CAT
>>+	default n
>>+	help
>>+	  Sheer bloat.
>>+
>
>Rob, this is wrong!
>Please make sure not to leak your local modifications into svn
>*partially*.
>
>Please fix, either by checking in the code or by removing this pointless
>config entry, thanks in advance.. :-P
>
>> config CONFIG_CHGRP
>> 	bool "chgrp"
>> 	default n
>>@@ -173,7 +180,7 @@
>> 	  du is used to report the amount of disk space used
>> 	  for specified files.
>> 
>>-config CONFIG_FEATURE_DU_DEFALT_BLOCKSIZE_1K
>>+config CONFIG_FEATURE_DU_DEFAULT_BLOCKSIZE_1K
>> 	bool "Use a default blocksize of 1024 bytes (1K)"
>> 	default y
>> 	depends on CONFIG_DU

Rob, along the same lines, you broke
dumpleases
udhcpc
udhcpd
again.. See
http://www.busybox.net/cgi-bin/viewcvs.cgi/trunk/busybox/include/applets.h?rev=14949&view=log
for r14898
(http://www.busybox.net/cgi-bin/viewcvs.cgi?rev=14898&view=rev)
and r14909
(http://www.busybox.net/cgi-bin/viewcvs.cgi?rev=14909&view=rev)

Please fix, it doesn't make sense if vapier and i re-enable it since you
checkin stuff straight from your devel-tree instead of isolating a patch
you intend to checkin into a pristine copy and check/commit from there..

kind regards,
Bernhard



More information about the busybox mailing list