[PATCH] hdparm 6.6 1/2

Rob Landley rob at landley.net
Wed May 3 15:16:47 UTC 2006


On Sunday 30 April 2006 4:52 am, Tito wrote:

> > > And no, util-linux isn't doing it cleanly either.  They just hide the
> > > ugliness by nesting #include files.  mount/loop.h #includes my_dev_t.h
> > > which #includes <linux/posix_types.h> and <linux/version.h> just like
> > > we do, because THERE IS NO ALTERNATIVE.
> >
> > I do believe that we should never directly include kernel headers when
> > there's a better way to do it, but I also believe that block copying the
> > contents of the kernel headers into our program does not qualify as a
> > better way to do it.
>
> Ok, maybe we should add this to programming.html.

Did that a couple days ago, the email reply window is still open on my desktop 
so I'm guessing I didn't reply to it... :)

> BTW: i've posted one more cleanup patch (06) that removes obsolete
> and dead code from hdparm syncing it with the latest version.
> If you have some time could you take a look at it.

Did I do that?  (I remember looking at it, but that doesn't mean much...)

Rob
(Chewing through the backlog...)
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list