[PATCH] ls: clean up memory leak
Rob Landley
rob at landley.net
Tue May 2 19:50:16 UTC 2006
On Tuesday 02 May 2006 11:16 am, Shaun Jackman wrote:
> On 5/1/06, Rob Landley <rob at landley.net> wrote:
> > If it's from Vladimir I'd like to confirm that it's under the GPL, since
> > he's explicitly stated that some of his previous patches were not GPL.
> >
> > And I'm not against UTF-8 support, I'd just like it to be done cleanly,
> > and the CONFIG option would need to go in before stuff using that CONFIG
> > option.
>
> Hello Rob,
>
> Please apply my original patch, which is free of the UTF-8 blob, fixes
> the memory leak with which I was originally concerned, and is a clean
> patch.
The one from 4/21?
Applied.
This applet could use some general #ifdef cleanup, by the way. (I noticed
that if you enable all features of ls except recursion and it gives a
warning...)
At some point, a big CONFIG_ cleanup is called for, which involves a move to
ENABLE but isn't quite the same thing. A todo item...
Rob
--
Never bet against the cheap plastic solution.
More information about the busybox
mailing list