[PATCH] hdparm size reduction

[Rob Landley]

On Saturday 29 April 2006 3:14 pm, Tito wrote:
> Hi,
> this patch applies on top of the last applied patches of Denis
> and removes some dead code in identify(),
> some obsolete  code in process_dev() and some obsolete functions
> (no_scsi(), no_xt(), no_scsi_no_xt()) as in latest hdparm6.6.
>
> Please apply.

The first two hunks were rejected.

What's the deal with chksum?  In the previous code, it was never being set (it 
was only set in the dead code that was never reached), and now it's tested in 
one place where they only care that' it's zero.  There's another place that 
we print it and say it's correct, but we never actually _test_ it so how do 
we know...?

> Ciao,
> Tito

Rob
-- 
Never bet against the cheap plastic solution.