[PATCH] standardize on KERNEL_VERSION(a,b,c) test

[Rob Landley]

On Friday 31 March 2006 3:50 pm, Allan Clark wrote:
> > I have no immediate interest in solving this non-problem, but if somebody
> > else does I'm not standing in their way.  (I expect the build to break
> > repeatedly in the process, in ways it's not breaking now, and I expect
> > the benefits of the results to be hard to measure.  I'm not exactly
> > enthusiastic about it. But other than needless churn I don't see anything
> > _wrong_ with it, per se...)
>
> It is an issue, though.  The fewer unnecessary headers, the fewer
> rebuilds when a header changes.

If stdio.h is changing out from under you, you have bigger problems.

> > > 1) include that header (we're avoiding that, right?), or
> > > 2) fail if that header's sentry is not found.
> >
> > If you have to check for the header's sentry, just #include the darn
> > header. They're all surrounded by guards.
>
> "we're avoiding that, right?" above.  I do see the logic that I
> missed: if you need it, then either it's included by the original *.c
> file, or you include it at the header that uses its types.  My bad. :(
>
> [...]
>
> I still push for reducing the headers you don't need -- I'll do it
> myself if no one else wants to, if I have some assurance it'll get
> merged.

Check with Shaun Jackman, who keeps submitting extra #include statements for 
newlib, and the MacOSX guys who seem to have similar concerns, but yeah.  
Removing unneeded lines is generally a good thing. :)

I can regression test against Red Hat 9, current ubuntu, and uclibc-0.9.28, 
but I haven't got a test setup for newlib or macosx.

Rob
-- 
Never bet against the cheap plastic solution.