patch: unzip succeeds with CRC errors

[Rob Landley]

On Tuesday 28 March 2006 1:03 pm, Rich Felker wrote:
> > What does "tar" do?
>
> In a tar file, either the damage is undetectable or unrecoverable,
> IIRC. Someone correct me if I'm wrong.

Well, I mostly meant a bzipped or gzipped tar. :)

> > I lean towards thinking that if you want to do forensic work on damaged
> > zip files, the full info-zip package might be a good idea.  Busybox has
> > always focused on "good enough for 99.9% of the cases, and not behaving
> > stupidly the rest of the time".
>
> I disagree strongly, for two reasons:

You care about this issue more than I do, and I've learned to listen and defer 
to other people's judgment in cases like that...

> If it added significant code size to support extracting zips with bad
> CRC, I would agree with omitting it or making it optional. But in fact
> the code size is essentially the same either way.

Important argument in its' favor...

> There are plenty of other causes. Usually corrupted data is caused by
> accidentally overwriting part of a file or filesystem. For instance,
> running mke2fs on an existing filesystem.. :) This is the sort of real
> world disaster situation that rescue disks are made for.

Ok, I'm convinced.

> Rich

Rob
-- 
Never bet against the cheap plastic solution.