[PATCH] Remove extraneous cruft from end of libbb/Makefile.in

Rob Landley rob at landley.net
Tue Mar 28 19:48:56 UTC 2006


On Tuesday 28 March 2006 4:44 am, Bernhard Fischer wrote:
> On Tue, Mar 28, 2006 at 03:34:45AM -0500, Robert P. J. Day wrote:
> >  [NOTE:  This stuff at the end of libbb/Makefile.in doesn't
> >**appear** to have any value but I've been wrong before.]
>
> These are needed for CONFIG_BUILD_AT_ONCE.
>
> >  [NOTE 2:  I just realized this won't apply cleanly if my earlier
> >patch is applied first but that would be easy to fix.]
>
> I fail to see the benefit of your previous patch to add vpath.
> Doesn't this just make the build (slightly) slower since you removed the
> explicit path to the source? It sounds like with your proposed patch,
> make would have to iterate over a list (of several vpath's) instead of
> the explicit path..
>
> Can you show us a diff between
> make clean ; (make -d -p) 2>&1 >&1 | tee OUT.orig
> and the same with your "earlier" patch applied?

Considering section 4.4.2 "vpath" (just after section 4.4.1, "VPATH") is where 
my bookmark happens to be right now in my read through the makefile manual, I 
think I'm going to stay out of this one. :)

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list