[busybox] small glitch in mount.c ?

Rob Landley rob at landley.net
Tue Mar 28 19:21:20 UTC 2006


On Tuesday 28 March 2006 4:22 am, Bernhard Fischer wrote:
> in mount.c:551 you free(fstype) which is not yours as you
> did fstype=optarg before (without fstype=xstrdup(optarg) )
>
> Can you please look at it and eventually fix it?
>
> I didn't look at mount.c closely, though, but i did see a message about
> freeing invalid mem there..

I just traced through and you're right, I'm consistently making sure it's 
never set to memory we allocate.  It's either from the fstab lookup functions 
(which have their own static buffer), or set to a constant string.

Fixed.

Thanks,

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list