[PATCH] Remove extraneous cruft from end of libbb/Makefile.in

[Robert P. J. Day]

On Tue, 28 Mar 2006, Bernhard Fischer wrote:

> On Tue, Mar 28, 2006 at 03:34:45AM -0500, Robert P. J. Day wrote:
> >
> >  [NOTE:  This stuff at the end of libbb/Makefile.in doesn't
> >**appear** to have any value but I've been wrong before.]
>
> These are needed for CONFIG_BUILD_AT_ONCE.

whoops, quite right, my mistake.

> >  [NOTE 2:  I just realized this won't apply cleanly if my earlier
> >patch is applied first but that would be easy to fix.]
>
> I fail to see the benefit of your previous patch to add vpath.
> Doesn't this just make the build (slightly) slower since you removed
> the explicit path to the source? It sounds like with your proposed
> patch, make would have to iterate over a list (of several vpath's)
> instead of the explicit path..

whether or not it makes the build slightly slower is, IMHO, not
relevant.  it's a question of clean(er) design.  i've never been a fan
of hard-coding ${SRCDIR} into every instance of a source file
dependency -- that's precisely the thing "vpath" is designed to avoid.

in addition to removing that clutter from the makefile, using vpath
also allows the source files to possibly come from more than one
source directory in the future.

in any event, of course you can leave in all of the "$(srcdir)"
prefixes on the source file dependencies.  but why *would* you when a
simple vpath directive makes all of that unnecessary?

rday