libbb/create_icmp6.socket.c: why is entire code conditional?

[Rob Landley]

On Sunday 26 March 2006 7:15 am, Robert P. J. Day wrote:
>   i'm a bit weirded out by the fact that the entirety of the source in
> the file libbb/create_icmp6_socket.c is conditionally included by
>
>   #ifdef CONFIG_FEATURE_IPV6
>   ...
>   #endif
>
> that strikes me as unnecessarily obtuse.

It means the makefile should be fixed.

> it would seem to make more 
> sense to do one of two things:
>
> 1) combine both create_icmp_socket.c and create_icmp6_socket.c into a
> single source file, and put the conditional inclusion of the IPV6
> stuff in *that* file, or
>
> 2) remove the conditional inclusion and use the typical entry in
> Makefile.in of
>
>   LIBBB-$(CONFIG_FEATURE_IPV6)+= create_icmp6_socket.c
>
>
>   either one of those would seem to be a cleaner technique.

Either works for me.

(I don't use ipv6, but knowing that the whole of Korea shares a single class B 
address (65k routeable IPs), I understand the demand for it outside the US.  
Happy to see it fixed, can't personally test it...)

> rday

Rob
-- 
Never bet against the cheap plastic solution.