libbb/create_icmp6.socket.c: why is entire code conditional?

Robert P. J. Day rpjday at mindspring.com
Sun Mar 26 12:15:11 UTC 2006


  i'm a bit weirded out by the fact that the entirety of the source in
the file libbb/create_icmp6_socket.c is conditionally included by

  #ifdef CONFIG_FEATURE_IPV6
  ...
  #endif

that strikes me as unnecessarily obtuse.  it would seem to make more
sense to do one of two things:

1) combine both create_icmp_socket.c and create_icmp6_socket.c into a
single source file, and put the conditional inclusion of the IPV6
stuff in *that* file, or

2) remove the conditional inclusion and use the typical entry in
Makefile.in of

  LIBBB-$(CONFIG_FEATURE_IPV6)+= create_icmp6_socket.c


  either one of those would seem to be a cleaner technique.

rday





More information about the busybox mailing list