[PATCH] add a few new xfuns and use them as appropriate

Rob Landley rob at landley.net
Tue Mar 14 17:14:19 UTC 2006


On Tuesday 14 March 2006 1:45 am, Denis Vlasenko wrote:
> On Monday 13 March 2006 17:47, Rob Landley wrote:
> > On Monday 13 March 2006 1:58 am, Denis Vlasenko wrote:
> > > On Monday 13 March 2006 08:57, Denis Vlasenko wrote:
> > > > On Monday 13 March 2006 08:56, Denis Vlasenko wrote:
> > > > > Patches are posted as replies. Please apply.
> > > >
> > > > This patch adds xstat() and uses it where appropriate.
> > >
> > > This patch replaces open() with bb_xopen() where appropriate.
> > > --
> > > vda
> >
> > No, it also adds xsocket()
>
> Oops... stuff got mixed it a bit...
>
> > and adds at least one comment that it can't decide
> > whether or not to use it (the point at which I put it on the "to look at
> > later" pile.)
>
> That's because I am trying to do things in small enough steps
> in order to not annoy the maintainer ;)

Which is highly cool and I appreciate this.

My mount rewrite is more or less ready to check in (not necessarily fully 
debugged, but close enough to be usable), and I'm focusing on testing the 
rest of it right now (which is a bit of a pain, but I'm pushing through.  I 
could happily have remained in ignorance about MS_VERBOSE for some time). 

I'm not paying as much attention to things that don't need to go in this 
release right now, but I've got it all in a directory and next week I start 
to tackle the backlog.

> For example:
>
> -               int probe_fd = socket(AF_INET, SOCK_DGRAM, 0);
> +               int probe_fd = socket(AF_INET, SOCK_DGRAM, 0); /* maybe use
> xsocket? */
>
>                 if (probe_fd < 0) {
>                         bb_error_msg("socket");
>                         exit(2);
>                 }
>
> It's not 100% clear that xsocket will be identical here (will it exit with
> errorcode 2?). I am leaving it to later time by just adding a reminder.

From the comment it wasn't clear what the issue was.  Now I've forgotten which 
applet we're talking about. :)

> Thanks for applying stat.patch. Rest of them, rediffed & updated, are
> below. --

I got your email with the URL to the directory.

> vda

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list