coding style for who.c

Robin Farine robin.farine at terminus.org
Sat Mar 11 19:26:48 UTC 2006


On Saturday March 11 2006 19:50, Devin Bayer wrote:

> In addition, I dislike having to make
> 	if(a = strchr(str,'-'));
> into
> 	if((a = strchr(str,'-')));
>
> How can the second one be considered easier to read? To fix this
> you need to add -Wno-parentheses to the CPPFLAGS.

It is more to make explicit that you want an '=' instead of an '==' 
here than to improve readability, likewise for &, |, ... vs &&, 
||, ... In my opinion, this warning helps in spending time in tasks 
more interesting than debugging this kind of typos.

Robin



More information about the busybox mailing list