[PATCH] static const ints are evil

Denis Vlasenko vda at ilport.com.ua
Fri Mar 10 06:13:06 UTC 2006


On Thursday 09 March 2006 19:30, Rob Landley wrote:
> On Thursday 09 March 2006 1:16 am, Denis Vlasenko wrote:
> > Why? Because the are emitted into rodata segment, thats why!
> >
> > Below patch converts most of them into enum constants.
> > End result:
> >
> > # size busybox.org busybox.const
> >    text    data     bss     dec     hex filename
> >  790676   10820 1028484 1829980  1bec5c busybox.org
> >  789580   10820 1028484 1828884  1be814 busybox.const
> >
> > Patch is bzipped in order to fit into 40kb mailing list limit.
> > Also available at http://195.66.192.167/linux/bbox/const.patch
> > --
> > vda
> 
> The dump you appended at the start of the patch is no only egregiously long 
> (and thus makes it hard to read the actual patch), but when you try to apply 
> it it triggers a suprious patch for a file it can't find.
> 
> Try applying it.

:(

I placed fixed version at http://195.66.192.167/linux/bbox/const.patch
--
vda



More information about the busybox mailing list