confused about use of $(noconfig_targets)

Bernhard Fischer rep.nop at aon.at
Thu Mar 2 16:24:37 UTC 2006


On Thu, Mar 02, 2006 at 10:55:42AM -0500, Robert P. J. Day wrote:
>On Thu, 2 Mar 2006, Bernhard Fischer wrote:
>
>> On Thu, Mar 02, 2006 at 09:28:49AM -0500, Robert P. J. Day wrote:
>> >
>> >  (ahead of time, i'll apologize for what will probably be some
>> >easy/pedantic questions since i've decided, once and for all, to go
>> >thru the BB code and figure out exactly how it works.)
>> >
>> >  in the top-level Rules.mak, there a conditional inclusion of the
>> >.config file:
>> >
>> >  ifeq ($(filter $(noconfig_targets),$(MAKECMDGOALS)),)
>> >  -include $(top_builddir)/.config
>> >  endif
>>
>> This was already there before i touched any of busybox. Better ask
>> an elder :)
>
>note:  i'm fine with the *philosophy* of the above, it's a fairly
>straightforward technique.  i'm just not convinced of its
>*implementation*.  specifically, what if you invoke the makefile with
>mixed targets (some in that list, some not).  or is that just not
>meant to happen?

It wasn't ment to happen. Feel free to provide a patch.
>
>> >  as i read that, as long as *none* of your goals is in the list of
>> >$(noconfig_targets), you'll include the .config file.  (i'm a little
>> >leery of that check in the first place, but that's not the issue
>> >here.)
>>
>> Yes. If we're asked to do a noconfig_target, then don't pull in .config.
>
>so the above doesn't support multiple targets?  that's important to
>know.  (for instance, if i did "make allbareconfig _all".  what
>happens *then*?)

The above doesn't have anything to do with mixed targets, really.
The above says if _any_ non_config target is in MAKECMDGOALS, pull in
.config.

If you want to support mixed targets while not breaking make-3.80,
please submit a patch.




More information about the busybox mailing list