Pending patches status?
Denis Vlasenko
vda at ilport.com.ua
Thu Mar 2 07:18:06 UTC 2006
On Wednesday 01 March 2006 18:59, Rob Landley wrote:
> > Patches are at http://195.66.192.167/linux/bbox/
>
> Okay, let's take a look...
>
> Messing with fdisk is deferred until 1.1.2, and I'd prefer the rewrite
> approach.
>
> The free patch looks good, but huge and complicated. Let's see... With any
> change this big there's a few questionable bits (the ifupdown_main() bits,
> for example), but in general it looks ok. Applied.
>
> The make.patch one didn't get applied because the .o and .s bits at the end
> belong in Rules.mak. (What are they for, anyway?)
Without these rules:
# make archival/libunarchive/archive_xread_all.o
gcc -I/.share/usr/src2/bbox/busybox.tst/include -I/.share/usr/src2/bbox/busybox.tst/include -I/.share/usr/src2/bbox/busybox.tst/libbb -funsigned-char -Wall -Wstrict-prototypes -Wshadow -Os -march=i386 -mpreferred-stack-boundary=2 -falign-functions=0 -falign-jumps=0 -falign-loops=0 -fomit-frame-pointer -D_GNU_SOURCE -DNDEBUG i386 -c -o archival/libunarchive/archive_xread_all.o archival/libunarchive/archive_xread_all.c
gcc: i386: No such file or directory
make[1]: *** [archival/libunarchive/archive_xread_all.o] Error 1
make: *** [archival/libunarchive/archive_xread_all.o] Error 2
I do not know where did that "i386" in gcc command line come from,
I failed to find a way to see built-in implicit make rules.
# make archival/libunarchive/archive_xread_all.s
make[1]: *** No rule to make target `archival/libunarchive/archive_xread_all.s'. Stop.
make: *** [archival/libunarchive/archive_xread_all.s] Error 2
With them:
# make archival/libunarchive/archive_xread_all.o
gcc -I/.share/usr/src2/bbox/busybox.tst/include -I/.share/usr/src2/bbox/busybox.tst/include -I/.share/usr/src2/bbox/busybox.tst/libbb -funsigned-char -Wall -Wstrict-prototypes -Wshadow -Os -march=i386 -mpreferred-stack-boundary=2 -falign-functions=0 -falign-jumps=0 -falign-loops=0 -fomit-frame-pointer -D_GNU_SOURCE -DNDEBUG archival/libunarchive/archive_xread_all.c -c -o archival/libunarchive/archive_xread_all.o
# make archival/libunarchive/archive_xread_all.s
gcc -I/.share/usr/src2/bbox/busybox.tst/include -I/.share/usr/src2/bbox/busybox.tst/include -I/.share/usr/src2/bbox/busybox.tst/libbb -funsigned-char -Wall -Wstrict-prototypes -Wshadow -Os -march=i386 -mpreferred-stack-boundary=2 -falign-functions=0 -falign-jumps=0 -falign-loops=0 -fomit-frame-pointer -D_GNU_SOURCE -DNDEBUG archival/libunarchive/archive_xread_all.c -S -o archival/libunarchive/archive_xread_all.s
> Rooting around in my back email I'm mfailing to come up with descriptions for
> these patches right now. (I mentioned I have a cold?)
Yes you did :) Hope you will be healhty soon.
> Could you do a brief
> descrption of what each set (wget, top, and hdparm) tries to accomplish?
Patches at http://195.66.192.167/linux/bbox/ are updated with descriptions.
make.patch is modified.
--
vda
More information about the busybox
mailing list