[PATCH] aesthetics for interface.c, and proper printout for "sit0"

[Rob Landley]

On Monday 26 June 2006 5:50 pm, Robert P. J. Day wrote:
> On Mon, 26 Jun 2006, Rob Landley wrote:
> > On Monday 26 June 2006 8:01 am, Robert P. J. Day wrote:
> > >   now that i have commit access (whoo hoo!  a round for the house,
> > > barkeep, and put it on my tab), i figure i'll run potential patches
> > > past the collective first.
> > >
> > >   this patch has already been presented in two parts.  it's mostly
> > > aesthetic, but also cleans up the output format for the "sit0"
> > > interface to be consistent with that from the most recent net-tools.
> > >
> > >   comments?  i realize we're in feature freeze, but this is a fairly
> > > innocuous change and does fix the minor bug regarding sit0.  if it's
> > > too late for this sort of thing, i'll just hold off until after the
> > > official release.
> >
> > There's actually two things there, a cleanup and a new structure.
>
> actually, my first preference would have been to submit it as two
> separate commits based exactly on what you wrote.  i'll do it that
> way, then.

*shrug*  Splitting up patches mostly just makes them easier to review, and 
makes it so that if somebody narrows down bad behavior to a specific checkin 
we can figure out what the heck the patch in question did.  This one's small 
enough that neither is a major problem, in this instance.

(You can split patches down so far that it takes more work to review them just 
because of the granularity, too.  Not that that's necessarily relevant here 
either... :)

Rob
-- 
Never bet against the cheap plastic solution.