[PATCH] remove obsolete(?) code that handles net if aliases

Robert P. J. Day rpjday at mindspring.com
Tue Jun 20 21:25:09 UTC 2006


On Tue, 20 Jun 2006, Rob Landley wrote:

> On Tuesday 20 June 2006 12:21 pm, Robert P. J. Day wrote:
> >   this patch simply wipes out the code in interface.c/get_name() that
> > handles an optional alias portion after the interface name in the file
> > /proc/net/dev.  it would *seem* that, according to an earlier
> > commenter, that code hasn't been necessary in a while, but i'm quite
> > willing to be overruled.
> >
> > rday
> >
> > p.s.  of course, the current code is technically correct but why waste
> > the bytes?
>
> I have no familiarity with this section of code at all.  I tracked
> down the source of the /proc data to
> linux-2.6.17.1/net/core/dev.c:dev_seq_printf_stats() which is
> putting dev->name into the first field before the ":", so unless
> dev->name itself has a colon in it, this code can't produce it...
>
> *shrug*  Applied.

it was michael zick in an earlier posting that suggested that the
possibility of there being an alias after the actual interface name
disappeared back around the 2.2.x kernel.

that entire routine could probably be replaced with a one-line call to
xregcomp() but i'm not feeling that ambitious at the moment.  maybe
after 1.2.0.

rday



More information about the busybox mailing list