more issues with networking/interface.c and preprocessor directives

[Rob Landley]

On Monday 19 June 2006 3:07 pm, Robert P. J. Day wrote:
>   pedantically, that struct definition (regardless of what the comment
> says) is found in /usr/include/linux/ipv6.h (in the FC package
> glibc-kernheaders).  but the "#ifndef" is checking if the header file
> /usr/include/linux/in6.h has already been included.  is there no way
> that whole chunk can be written more clearly or more simply?  i don't
> know enough about the layout of glibc headers to be sure about this.
> (can't one just include the proper header file to include that struct
> definition?)

You'd think so, wouldn't you?  Sounds worth a try...

>   second, in that same file, we read:
>
> ...
> #ifndef HAVE_TXQUEUELEN
> #define HAVE_TXQUEUELEN 1
> #endif
> ...
>
> why is that being defined?  it doesn't appear to be used anywhere in
> that file or any other file in busybox.

Then remove it.

>   third,  the same might be said for the definition of IFF_DYNAMIC in
> both ifconfig.c and interface.c.  since it doesn't appear to be
> user-selectable, why not just hardcode it in, say, inet-common.h or
> something?

It's defined in /usr/include/linux/if.h which is probably #include by 
something that's included by something that traces back to a standard header, 
but rather than worry about it putting it inet-common.h makes sense to me.

> rday

Rob
-- 
Never bet against the cheap plastic solution.