svn commit: trunk/busybox/archival

Rob Landley rob at landley.net
Tue Jun 13 16:09:42 UTC 2006


On Tuesday 13 June 2006 11:29 am, Bernhard Fischer wrote:

> >+		/* TODO: xstat */
> >+		if (stat(filename, &stat_buf) < 0) {
> >+			bb_error_msg_and_die("Couldn't stat file %s", filename);
> >+		}
>
> /me shakes his head
> so what exactly is the point in adding a comment about doing the proper
> xstat there and not just plain doing it?
>
> It this something you procrastinate on purpose instead of doing it right
> while at it?

I honestly wasn't paying attention to that comment (well it's a comment) and 
thought it was talking about lstat().  You're right, I should have cleaned 
that up.

Fixed.

Thanks,

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list