making "test" an ash built-in

Paul Fox pgf at brightstareng.com
Thu Jun 8 21:43:01 UTC 2006


i wrote:
 > rob wrote:
 >  > One suggestion though: rather than moving the coreutils/test.c into libbb, 
 >  > might it make more sense to move it into the shell directory instead?  (Along 
 >  > with its config option?)
 ...
 > i think this is a good idea.  in fact, how about if i move the echo and
 > test applets into the shell subdirectory in their entirety -- i.e.,
 >     mv coreutils/{echo,test}.c libbb/bb_{echo,test}.c shell

well, i may think it's a good idea (i still do) but it's not what
i did.  instead, i moved the contents of libbb/bb_echo.c back
into coreutils/echo.c, which is a more reasonable place than
libbb.  this forces anyone who wants echo and test to be builtin
to ash to also have them available as applets.  their cost is
very small, and the number of people who wouldn't want them as
applets is also very small.

i think moving all of the "traditional" shell builtins from coreutils
to the shell subdirectory is a good plan -- it would also let you
choose whether or not to include the echo and test applets
independently of including the builtins -- but i just don't have
time right now. 

bernhard -- this also means i don't have time to review/merge the
other patch you sent this morning.  sorry.

paul
=---------------------
 paul fox, pgf at brightstareng.com



More information about the busybox mailing list