[PATCH] update: making "test" an ash built-in
Bernhard Fischer
rep.nop at aon.at
Thu Jun 8 13:11:59 UTC 2006
On Thu, Jun 08, 2006 at 08:53:51AM -0400, Paul Fox wrote:
> > Note that I replaced the rest of the bb_error_msg_and_die with only
> > bb_error_msg. You would not like the entire shell die just because you
> > entered wrong number of params to 'test', '[' or '[['.
> >
> > I would love to see it committed.
>
>i'll do it today, though i'll also look at rob's comments re: moving
>the test code to the shell subdir rather than libbb.
>
>i also see that aldot committed a bunch of message changes, which
>is why my version didn't merger correctly. sigh. thanks for re-working
>the code.
Hm, well it saves space.. :)
Could you please also incooperate the test patch i just sent? It
restructures the code to remove most of the prototypes and unrolls a
case-statement. Also -- from the looks -- there should perhaps be an
else statement between looking if we are [[ or [. See the respective
comment in said patch.
TIA,
Bernhard
More information about the busybox
mailing list