[patch] various bugs and strncpy abuse followup

[Tito]

On Wednesday 7 June 2006 22:17, Rob Landley wrote:
> On Wednesday 07 June 2006 2:43 am, Tito wrote:
> > On Wednesday 7 June 2006 00:34, Erik Hovland wrote:
> >
> > Hi,
> > some comments about the devfsd patch:
> 
> I just marked devfsd as deprecated.  It's not going away in 1.2.x, and 
> probably not in 1.3.x, but I don't plan on it being around forever.
> 
> Just FYI.

Please apply the last part of the patch as it fixes a real bug:

@@ -1311,9 +1313,9 @@
        /* compare_string_array returns i>=0  */
        i=compare_string_array(field_names, variable);

-       if ( i > 6 && (i > 1 && gv_info == NULL))
-                       return (NULL);
-       if( i >= 0 || i <= 3)
+       if (i > 6 || (i > 1 && gv_info == NULL) || i < 0)
+               return (NULL);
+       if( i <= 3  && i >= 0 )
        {
                debug_msg_logger(LOG_INFO, "%s: i=%d %s", __FUNCTION__, i ,field_names[i+7]);
                return(field_names[i+7]);

Ciao,
TIto
> Rob