[PATCH] fix minor bugs in hdparm and don't block when reading from stdin

Tito farmatito at tiscali.it
Thu Jun 8 06:05:13 UTC 2006


On Wednesday 7 June 2006 23:25, Rob Landley wrote:
> On Wednesday 07 June 2006 10:29 am, Mike Frysinger wrote:
> > On Friday 02 June 2006 09:33, Tito wrote:
> > > +++ miscutils/hdparm.c  2006-06-02 15:21:51.000000000 +0200
> > > @@ -2124,8 +2124,8 @@
> > > -               USE_FEATURE_HDPARM_GET_IDENTITY(get_IDentity = (c ==
> > > 'I')); -               USE_FEATURE_HDPARM_GET_IDENTITY(get_identity = (c
> > > == 'i')); +               USE_FEATURE_HDPARM_GET_IDENTITY(get_IDentity |=
> > > (c == 'I')); +               USE_FEATURE_HDPARM_GET_IDENTITY(get_identity
> > > |= (c == 'i'));
> >
> > merged, thanks
> > -mike
> 
> I know I'm a bit behind, but when you merge only part of a patch that was cc'd 
> to me, so that it conflicts with the cleaned up version of the patch in my 
> tree (with an #if ENABLE turned into if (ENABLE) like it should have been in 
> the first place)...  Net, it actually slows things down.

Hi,
root at localhost:/dev/pts/2:/root/Desktop/busybox# make
  CC miscutils/hdparm.o
/root/Desktop/busybox/miscutils/hdparm.c: In function ‘hdparm_main’:
/root/Desktop/busybox/miscutils/hdparm.c:2190: warning: implicit declaration of function ‘identify_from_stdin’
  AR cru miscutils/miscutils.a
  LINK busybox_unstripped
  STRIP busybox
root at localhost:/dev/pts/2:/root/Desktop/busybox#         

The if(ENABLE) would better be an #if ENABLE to avoid the above error message
please fix it.


Thanks and Ciao,
Tito

> Just sayin'
> 
> Rob



More information about the busybox mailing list