ok, what's the official take on "endianness"? and hdparm problem

Rob Landley rob at landley.net
Wed Jun 7 04:14:35 UTC 2006


On Tuesday 06 June 2006 5:35 pm, Tito wrote:
> >  Even with the nice new macros, hdparm still produced the same errors as
> > in earlier versions (svn 15237). I removed the above test and the busybox
> > hdparm now produces the same result as the ubuntu hdparm (v6.1) I have
> > attached a patch for this, but have only tested it on one ppc system so
> > far. There also may be some other cleanup that you might want to do as
> > gcc reports that buf[] is now unused.
> >    ...ken...
>
> In fact in newer hdparm code this test is gone.
> From hdparm 6.6+:

So they moved the endianness adjustment from the one common function to 
independently do it in each of the callers, to maximize duplicated code.  
Nice to know.

> 	/* calculate checksum over all bytes */
> 	for(ii = GEN_CONFIG; ii<=INTEGRITY; ii++) {
> 		chksum += val[ii] + (val[ii] >> 8);
> 	}

They're actually doing a checksum now?

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list