[PATCH] Include netinet/in.h in libbb.h

Robert P. J. Day rpjday at mindspring.com
Sat Jun 3 22:46:06 UTC 2006


On Sat, 3 Jun 2006, Bernhard Fischer wrote:

> On Sat, Jun 03, 2006 at 12:25:36PM -0600, Shaun Jackman wrote:
> >On 7/25/05, Rob Landley <rob at landley.net> wrote:
> >...
> >>But applied anyway...
> >>
> >>Rob
> >
> >This patch was never applied; please apply it now.
> >
> >libbb.h uses struct sockaddr_in which is defined in netinet/in.h but
> >never included.
>
> This patch shouldn't be needed anymore since the order of includes
> were restructered recently. Applets have to include busybox.h as the
> first include, lib*/* has to include libbb.h as the first include.
>
> Applets and library functions MUST not include any header which is
> included by platform.h, busybox.h and platform.h, libbb.h
> respectively.

all right, this is just plain creeping me out, when people start
talking about a *required order* of header file inclusion.  this is
just plain not good.

rday



More information about the busybox mailing list