[BUG] hdparm & uClibc: BLKGETSIZE64 undeclared

Yann E. MORIN yann.morin.1998 at anciens.enib.fr
Sat Jun 3 22:43:30 UTC 2006


Hello all!

Before I surrender to Morpheus, here is a nitpick in hdparm:

/home/ymorin/dev/src/busybox-svn/miscutils/hdparm.c: In function `do_blkgetsize':
/home/ymorin/dev/src/busybox-svn/miscutils/hdparm.c:1373: error: `BLKGETSIZE64' undeclared (first use in this function)
/home/ymorin/dev/src/busybox-svn/miscutils/hdparm.c:1373: error: (Each undeclared identifier is reported only once
/home/ymorin/dev/src/busybox-svn/miscutils/hdparm.c:1373: error: for each function it appears in.)

Toolchain is:
binutils-2.16.1
gcc-3.4.4
uClibc-0.9.28
linux-libc-headers-2.6.12.0

Target is armv5b-nslu2-linux-uclibc

In glibc, BLKGETSIZE64 is defined in sys/mount.h
In linux headers, it is defined in linux/fs.h
In uClibc, it is not defined anywhere.

In busybox, we do (re)define it in:
e2fsprogs/blkid/blkid_getsize.c:48
e2fsprogs/ext2fs/getsize.c:47
util-linux/fdisk.c:55

What is the best solution here?

Regards, and for those in the same area as me, good night, and sleep well!
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |   ^                |
| --==< °_° >==-- °---.----------------:  X  AGAINST      |  /e\  There is no  |
| web: ymorin.free.fr | SETI at home 3808 | / \ HTML MAIL    |  """  conspiracy.  |
°---------------------°----------------°------------------°--------------------°



More information about the busybox mailing list