[PATCH] .config.mak and CROSS_COMPILE fails with check_cc

Shaun Jackman sjackman at gmail.com
Mon Jul 10 17:17:03 UTC 2006


.config.mak is included after the check_cc macros run. The check_cc
macro requires that CROSS_COMPILE be defined. The best solution I have
is to move the inclusion of .config.mak up before the check_cc macro.
Please apply or suggest an alternative solution.

I only started seeing this error after I tried an out-of-source-tree
build -- aka make O=_build. I don't know why this bug doesn't seem to
affect in-source-tree builds.

Cheers,
Shaun

2006-07-10  Shaun Jackman  <sjackman at gmail.com>

	* Rules.mak: Include .config.mak before check_cc.

--- Rules.mak	a9b58db97585dfa13f1bb0ffd07cfb7e700c4ee9
+++ Rules.mak	b3ed0397b2fcc836626854adfdb170e9f67dda55
@@ -56,6 +56,9 @@
  CFLAGS+=$(CHECKED_CFLAGS)
  ARFLAGS=cru

+# Include the user-supplied flags.
+-include $(top_builddir)/.config.mak
+
  # gcc centric. Perhaps fiddle with findstring gcc,$(CC) for the rest
 # get the CC MAJOR/MINOR version
  CC_MAJOR:=$(shell printf "%02d" $(shell echo __GNUC__ | $(CC) -E -xc
- | tail -n 1))
@@ -320,10 +323,6 @@
     CFLAGS += -DINIT_SCRIPT='"$(BB_INIT_SCRIPT)"'
  endif

-# Put user-supplied flags at the end, where they
-# have a chance of winning.
--include $(top_builddir)/.config.mak
-
 #------------------------------------------------------------
 # Installation options
  ifeq ($(strip $(CONFIG_INSTALL_APPLET_HARDLINKS)),y)
-------------- next part --------------
2006-07-10  Shaun Jackman  <sjackman at gmail.com>

	* Rules.mak: Include .config.mak before check_cc.

--- Rules.mak	a9b58db97585dfa13f1bb0ffd07cfb7e700c4ee9
+++ Rules.mak	b3ed0397b2fcc836626854adfdb170e9f67dda55
@@ -56,6 +56,9 @@
 CFLAGS+=$(CHECKED_CFLAGS)
 ARFLAGS=cru
 
+# Include the user-supplied flags.
+-include $(top_builddir)/.config.mak
+
 # gcc centric. Perhaps fiddle with findstring gcc,$(CC) for the rest
 # get the CC MAJOR/MINOR version
 CC_MAJOR:=$(shell printf "%02d" $(shell echo __GNUC__ | $(CC) -E -xc - | tail -n 1))
@@ -320,10 +323,6 @@
     CFLAGS += -DINIT_SCRIPT='"$(BB_INIT_SCRIPT)"'
 endif
 
-# Put user-supplied flags at the end, where they
-# have a chance of winning.
--include $(top_builddir)/.config.mak
-
 #------------------------------------------------------------
 # Installation options
 ifeq ($(strip $(CONFIG_INSTALL_APPLET_HARDLINKS)),y)


More information about the busybox mailing list