any value in configuring minimum password length?

Tito farmatito at tiscali.it
Mon Jul 3 19:57:40 UTC 2006


On Monday 3 July 2006 18:58, Rob Landley wrote:
> On Sunday 02 July 2006 3:47 pm, Tito wrote:
> > -	/* Add 1 for each type of characters to the minlen of password */
> > +	/* Add 2 for each type of characters to the minlen of password */
> > 	int size = MINLEN + 8;
> 
> Actually, changing the code to match the comment might be better.

The code matched the comment in the beginning,
You changed it when you committed the patch
without fixing the comment.

So, what you want to do here:

int size = MINLEN + 4;

or

int size = MINLEN + 8;

> And if you're making MINLEN configurable, why aren't you making the increment 
> size be configurable?  (Or the number of different types of characters 
> required before it increments the required length?)  What's the rationale for 
> exposing one but not the other?

Maybe it is best to not expose them at all.
MINLEN was intended just for the programmer so
that if this value would ever be changed to 
another standard fixing the code would have been
easier.

Ciao, 
Tito
 
> You see why I didn't want to go there?
> 
> Rob



More information about the busybox mailing list