strangeness involving e2fsprogs header files

[Mike Frysinger]

On Monday 03 July 2006 07:53, Robert P. J. Day wrote:
>   in my travels through the source code, i wandered across the fact
> that a number of header file inclusions under e2fsprogs use relative
> pathnames:
>
>   e2fsprogs/e2p/uuid.c:#include "../ext2fs/ext2_types.h"
>   e2fsprogs/e2p/e2p.h:#include "../ext2fs/ext2_fs.h"
>   e2fsprogs/blkid/read.c:#include "../uuid/uuid.h"
>   e2fsprogs/ext2fs/mkjournal.c:#include "../e2p/e2p.h"
>   e2fsprogs/ext2fs/mkjournal.c:#include "../e2fsck.h"

this was done on purpose ... since the build system tends to be on the fragile 
side, using paths such as these:

>   #include "ext2fs/ext2_types.h"
>   #include "ext2fs/ext2_fs.h"

is no good as they may pick up the standard e2fsprogs header files 
in /usr/include/ and it'd be a while before people noticed (or we'd get to 
chase down funky build errors)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20060703/a1e78bfc/attachment-0002.pgp