[patch] bug #249
Bernhard Fischer
rep.nop at aon.at
Thu Jan 19 09:19:42 UTC 2006
On Wed, Jan 18, 2006 at 05:10:54PM -0600, Rob Landley wrote:
>On Wednesday 18 January 2006 09:44, Bernhard Fischer wrote:
>> Hi,
>>
>> The patch attached to http://bugs.busybox.net/view.php?id=249
>> seems to be applied for the most part. The one code-line which wasn't
>> applied is attached.
>>
>> Should we add a note to TODO to audit read-only data (via objdump -x)?
>
>Yes, but const has nothing to do with read-only data. Const just says that
>you can't modify this data through this pointer.
>
>String constants should be in a read-only data section anyway unless you
>specify -fwriteable-strings, which we don't. (man gcc for details.)
>
>Const isn't an optimization, const is just pedantic typechecking. And I've
>honestly never seen it find a real bug in anything.
It's not about finding bugs but rather about more optimisations kicking
in if stuff is flagged const.
More information about the busybox
mailing list