[patch] bug #249

Rob Landley rob at landley.net
Wed Jan 18 23:10:54 UTC 2006


On Wednesday 18 January 2006 09:44, Bernhard Fischer wrote:
> Hi,
>
> The patch attached to http://bugs.busybox.net/view.php?id=249
> seems to be applied for the most part. The one code-line which wasn't
> applied is attached.
>
> Should we add a note to TODO to audit read-only data (via objdump -x)?

Yes, but const has nothing to do with read-only data.  Const just says that 
you can't modify this data through this pointer.

String constants should be in a read-only data section anyway unless you 
specify -fwriteable-strings, which we don't.  (man gcc for details.)

Const isn't an optimization, const is just pedantic typechecking.  And I've 
honestly never seen it find a real bug in anything.

Rob
-- 
Steve Ballmer: Innovation!  Inigo Montoya: You keep using that word.
I do not think it means what you think it means.



More information about the busybox mailing list