[PATCH] shared libbusybox, option for IMA mode

Rob Landley rob at landley.net
Wed Jan 18 22:38:53 UTC 2006


On Wednesday 18 January 2006 10:08, Bernhard Fischer wrote:
> Some applets can't be compiled with gcc-2.95, iirc. I, personally,
> wouldn't knock 2.95 out forcefully, but i admit that i don't use it
> anymore.

I just got a test environment together for Red Hat 7.2 with the evil that is 
gcc 2.96, but if that doesn't build against that I'm only likely to fix it if 
it's a really, really easy fix.

> >What is "naked-include"?
>
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/?cvsroot=src
> But apparently the ansidecl.h comes from gcc, fwiw..
>
> Attached patch was tested with gcc versions
> -3.3 -3.4 -4.0 -4.1-HEAD -4.2-HEAD
>
> ok to apply?
> Bernhard

Two things:

1) Does this work if it's on the left of the symbol (with the other type 
information, since it's basically funky type information)?  Having something 
other than the symbol being defined at the right edge makes it hard to read 
what the actual symbol name being defined is.

If we put this in a standard place, say after the other type information like 
"unsigned long int" but before the actual symbol name, it would a lot be 
easier for newbies to parse.  (Heck, it'd be a lot easier for me to parse 
too.  As with most programmers I find reading source code to be at about as 
much work as writing it...)

2) Perhaps the attribute_thingy names should be ATTRIBUTE_THINGY so it's more 
obvious it's a macro?  (Looking at the patch, this markup is really confusing 
if you don't know what it is.  An allcaps name at least says "macro, go look 
in the header files"...)

Other than that it looks good to me.

> PS: Rules.mak still talks about version 1.1.0-rc1, shouldn't we bump
> this to something like 1.1.1-pre0 ?

Yeah, time to update that.  Feel free. :)

Rob
-- 
Steve Ballmer: Innovation!  Inigo Montoya: You keep using that word.
I do not think it means what you think it means.



More information about the busybox mailing list