[PATCH] add a new unlzma applet
Rob Landley
rob at landley.net
Wed Jan 18 22:00:23 UTC 2006
On Wednesday 18 January 2006 09:51, Roberto A. Foglietta wrote:
> AFAIK, for a little I see about lzma and 7zip it could manage all
> compression algorithms (in theory)... so ti should be used to manage the
> others that BB have too (in future).
The functions I commented on were all marked "always_inline", and the
remaining few are speed_inline, so effectively you'd be factoring it out into
macros. This saves space how?
> Even if I am wrong I suggest you to do not breaks API consistency but
> at least commets out the rc_free and replace with smaller code warning
> future developers what/why you have done. I hope this helps.
In order to be compatible with what?
Busybox only factors stuff out into separate libraries when different users
can share code. There's only one user of this, and even if there were too
the inlining means they wouldn't share code anyway.
Rob
--
Steve Ballmer: Innovation! Inigo Montoya: You keep using that word.
I do not think it means what you think it means.
More information about the busybox
mailing list