[PATCH] passwd size reduction and request for testing: take 4
Tito
farmatito at tiscali.it
Mon Jan 16 07:26:19 UTC 2006
Hi,
This is take 4 of passwd size reduction (take somehow didn't make it to
the list, maybe the size was too big ?).
and just adds a minor fix (see 9) and a feature (see 10).
I've fixed the errors pointed out by Rob Landley in v.2.
The program now acts more like the real passwd on my linux box:
1) loop as long as a good (not easy to guess) new password is typed (for normal user)
2) override obscure password checking for root
3) loop and retry on password retype mismatch.
4) use bb_do_delay in all errors related to asking for the old password in new_password() .
5) rip out -a switch (non standard: on my system it is -a -all), hope nobody complains.....
6) default to use salted passwords (more secure?!).
7) fix the license as suggested on the list.
8) code cleanup
9) Don't ask for old password again if obscure or retype fails.
10) Allow max 3 retries.
Size reduction is:
root at localhost:/dev/pts/0:/root/Desktop/busybox/loginutils# size passwd.o.orig
text data bss dec hex filename
3166 0 160 3326 cfe passwd.o.orig
1973 4 289 2266 8da loginutils/passwd.o
The patch is big and needs auditing and review by the list members.
So i am posting it also as drop in replacement
to make code auditing easier.
Thanks in advance to all for your help,
Ciao,
Tito
PS: Sorry for the resend maybe my mail client or the my provider's snmp are messed up.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: passwd04.patch.tar.gz
Type: application/x-tgz
Size: 5636 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20060116/3c602fd2/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: passwd.c.tar.bz2
Type: application/x-tbz
Size: 3379 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20060116/3c602fd2/attachment-0001.bin
More information about the busybox
mailing list