[PATCH] passwd size reduction and request for testing: take 2
Tito
farmatito at tiscali.it
Fri Jan 13 20:43:11 UTC 2006
Hi,
This is take 2 of passwd size reduction.
I've fixed the errors pointed out by Rob Landley.
The program now acts more like the real passwd
on my linux box:
1) loop as long as a good (not easy to guess) new password is typed (for normal user)
2) override obscure password checking for root
3) loop and retry on password retype mismatch.
4) use bb_do_delay in all errors related to asking for the old password in new_password() .
5) rip out -a switch (non standard: on my system it is -a -all), hope nobody complains.....
6) default to use salted passwords (more secure?!).
7) fix the license as suggested on the list.
8) code cleanup
9) more size reduction:
root at localhost:/dev/pts/0:/root/Desktop/busybox/loginutils# size passwd.o.orig
text data bss dec hex filename
3166 0 160 3326 cfe passwd.o.orig
1952 4 289 2245 8c5 passwd.o
The patch is big and needs auditing and review by the list members.
So i am posting it also as drop in replacement
to make code auditing easier.
Thanks to all for your help
Ciao,
Tito
-------------- next part --------------
A non-text attachment was scrubbed...
Name: passwd.c
Type: text/x-csrc
Size: 8087 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20060113/4cd35b70/attachment.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: passwd02.patch
Type: text/x-diff
Size: 17140 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20060113/4cd35b70/attachment.bin
More information about the busybox
mailing list