[PATCH] mdev: fix bug with minor number parsing

Rob Landley rob at landley.net
Thu Jan 12 23:04:46 UTC 2006


On Thursday 12 January 2006 00:42, Frank Sorenson wrote:
> Good point about the brittleness.  Another fix might be to test both
> on the null termination and \n:
> for (s = temp; *s && (*s != '\n') ; s++) {

Yeah, I thought about that, but it's a waste of bytes if the kernel's behavior 
_is_ consistent.  (And in busybox-land, an extra 4 bytes that aren't _needed_ 
is pretty galling too...)

This is a borderline case either way. :)

> At any rate, it's probably just something to be aware of
> in case sysfs is ever changed.

If it breaks, I think we'll notice.  This isn't the kind of subtle breakage 
you really have to worry about, this is "I upgraded the kernel and now it 
doesn't boot".

> Frank

Rob
-- 
Steve Ballmer: Innovation!  Inigo Montoya: You keep using that word.
I do not think it means what you think it means.



More information about the busybox mailing list