[CFT][patch] buildsys touch-up and standalone applets
Mike Frysinger
vapier at gentoo.org
Tue Feb 28 06:24:40 UTC 2006
some nitpicky stuff from just glancing at the patch ...
+ export LD_LIBRARY_PATH="$(pwd)"
+ ./busybox
the quoting is unnecessary, and generally `` is more portable than $() ...
+top_srcdir:=$(shell cd $(dir $(firstword $(MAKEFILE_LIST))) && /bin/pwd)
+ PACKAGE_OUTPUTDIR := $(shell cd $(O) && /bin/pwd)
is the absolute path a good idea ?
+ifdef V
+ ifeq ("$(origin V)", "command line")
do you really need to check that it came from the command line ? also, might
be nice to have this just before that:
+ifdef VERBOSE
+ V := $(VERBOSE)
+endif
+# Workaround for bugs in make-3.80
+# eval is broken if it is in a conditional
patch for the issue is here in case anyone cares:
http://viewcvs.gentoo.org/sys-devel/make/files/make-3.80-conditional-eval.patch
CROSS =$(subst ",, $(strip $(CROSS_COMPILER_PREFIX)))
+#")
CC = $(CROSS)gcc
what's the point of that additional line ?
+SED = sed
+AWK = awk
s/=/:=/
+# generic rules
+%.o: %.c ; $(compile.c)
you should add some rules for %.i and %.s generation too ;)
-mike
More information about the busybox
mailing list