ifupdown open for no purpose
Glenn L. McGrath
bug1 at ihug.co.nz
Sun Feb 26 09:11:41 UTC 2006
On Sat, 25 Feb 2006 23:42:55 -0500
Rob Landley <rob at landley.net> wrote:
> On Saturday 25 February 2006 7:25 pm, Glenn L. McGrath wrote:
> > On Sun, 26 Feb 2006 12:54:29 +1300
> >
> > "Glenn L. McGrath" <bug1 at ihug.co.nz> wrote:
> > > When in no action mode ifupdown was opening the state file for
> > > apparently no reason at all.
> > >
> > > It didnt no anything with it, bypasses the error checking code... it
> > > looks like it was there from the begining.
> >
> > The attahced patch also cleans up writing to the state file, any reason
> > why it would be opening in a+ and then truncating to 0 ?
>
> It seems like your new one doesn't seem to truncate the existing file, so if
> you write a shorter amount of data it could have trailing crap. Did I
> misread?
hmm, man page says open in "w" mode truncates the file to 0... not sure
whats going on, guess i iwll have to test it :)
> Also, this patch doesn't apply on top of the previous one.
Yea, it included the previous patch.
Ill look into it a resend one tommorow.
Glenn
More information about the busybox
mailing list