[PATCH] fdisk.c: major whitespace/style cleanup

Rob Landley rob at landley.net
Fri Feb 24 20:14:59 UTC 2006


On Friday 24 February 2006 12:32 pm, Vladimir N. Oleynik wrote:
> Stephen Warren wrote:
> >>Can remove in general to me fdisk from the busybox?
> >>Also do that want. I of my work did not give the under this GPL licenses.
> >>I asked to not touch my utilities.
> >
> > Well, I admit I don't quite understand what you mean, but...
> >
> > My copy of fdisk.c (admittedly from the "old" 1.00 release) quite
> > clearly states it's under a GPL license...
> >
> > Give that, how can any modifications you made *not* be GPL?
>
> My licenses more free by GPL.

According to the notices on the files when they were checked in, the license 
_is_ the GPL.

> Only one condition: before something to correct it would be necessary to
> ask the person who supports this work. Otherwise you will remain with what.

That restriction is not compatible with the GPL.  Read the license text.

As for adequate notification, we're talking about a project I mentioned back 
in November, that somebody just volunteered to do.  Just chopping the 5000 
lines of source code down to 2500 lines or so would be a big improvement.

According to `find . -name "*.c" | xargs wc | sort -nr | less`, fdisk.c is the 
third largest program in the entire source code tree.  Small and simple is 
the reason busybox exists, and in terms of line count this program (which is 
essentially a boot sector editor) is larger than sed, awk, and lash 
_combined_.

How is that a good thing?

> --w
> vodz

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list