[PATCH] make top.c even smaller #3

Rob Landley rob at landley.net
Tue Feb 21 14:58:21 UTC 2006


On Tuesday 21 February 2006 4:12 am, Vladimir N. Oleynik wrote:
> Denis Vlasenko wrote:
> > Vodz, do you want me to resend a patch with printf("%.*s", col,
> > s->short_cmd) trick dropped?
>
> Yes.
>
> With:
>
> 1) procps mainstream compatibility

A) What does that even mean?

B) Who cares?

C) If "mainstream compatibility" really is a serious issue then I'll take a 
look at rewriting top from scratch.  I'm pretty sure I can shrink it by at 
least 10%.

> 2) do not remove old_Hertz_detect() code. I unlike this code, but:
>     - its mainstream code
>     - and added by Erik

I checked to make sure it's not needed on 2.4 or 2.6 kernels.  We don't 
explicitly support the 2.2 kernel anymore.  (And if you want context for the 
lack of 2.2 support, think that we had to add back in the ability to build on 
Red Hat 7.2, which is a 2.4 kernel.)

Spending extra bytes on 2.2 support is the wrong call.

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list