[PATCH] don't use strptime if we can

Denis Vlasenko vda at ilport.com.ua
Thu Feb 16 11:46:52 UTC 2006


strptime() is large (at least glibc one):

--- z_sizes     Thu Feb 16 13:08:49 2006
+++ z_sizes_1   Thu Feb 16 13:23:34 2006
...
@@ -4166,6 +4163,7 @@
 00000290 t awk_getline
 00000291 T rtnl_talk
 00000293 T __mpn_mul
+0000029a t compare_keys
 0000029c t fileAction
 000002a0 T ether_aton_r
 000002a8 t read_int
@@ -4212,7 +4210,6 @@
 000002f7 T getopt_main
 000002f7 t transit_state_bkref
 000002fc T __gconv_get_path
-000002fe t compare_keys
 000002ff t do_show
 00000300 R _nl_C_LC_CTYPE_class
 00000303 T __getmntent_r
@@ -4437,7 +4434,6 @@
 000024e9 T __strtold_internal
 000024f5 T __strtod_internal
 00002a40 r translit_from_tbl
-00002a9e t strptime_internal
 00003214 T _IO_vfwprintf
 00003214 W vfwprintf
 00003214 T __vfwprintf

strptime() is used in sort.c (if CONFIG_FEATURE_SORT_BIG)
and tune2fs.c

tune2fs.c already has alternative code and we can use it.
sort.c is harder, I just added a FIXME.
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: strpt.patch
Type: text/x-diff
Size: 1120 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20060216/362ab72b/attachment.bin 


More information about the busybox mailing list