[PATCH] make top.c even smaller

Bernhard Fischer rep.nop at aon.at
Tue Feb 14 22:55:51 UTC 2006


On Tue, Feb 14, 2006 at 07:45:24PM +0100, Bernhard Fischer wrote:
>On Tue, Feb 14, 2006 at 08:35:21PM +0300, Vladimir N. Oleynik wrote:
>>Bernhard,
>>
>>>>diff -urpN busybox.fix2/procps/top.c busybox.fix3/procps/top.c
>>>>--- busybox.fix2/procps/top.c	Mon Feb 13 15:41:02 2006
>>>>+++ busybox.fix3/procps/top.c	Tue Feb 14 12:23:54 2006
>>>>@@ -51,13 +51,13 @@ static procps_status_t *top;   /* Hehe *
>>>>static int ntop;
>>>>
>>>>#ifdef CONFIG_FEATURE_USE_TERMIOS
>>
>>>can you please s/ifdef[[:space:]]*CONFIG_/if ENABLE_/gc
>>>while at it?
>>
>>What for?
>
>We want to remove CONFIG_ mid-term, AFAIU.

PS: vodz, i don't want to delve into me using a 16/4 {br,t}oken-ring
network at home (don't ask) while there is Fast Ethernet and GigaBit
Ethernet or even Infiniband around. Put short, it's not a good idea to
forcefully clash with leaks by the .... kernel.org namespace, and i'm
one of those affected by it. You could be next if you dare to have
sysctl enabled in your kernel or if somebody has the marvellous idea to
add a CONFIG_AWK subsystem to satisfy rfc4711 or thereabout and thusly
turns on awk in your busybox ;)
One could argue that thou shalt not include kernel-headers in userspace,
but given current state of affairs (in /usr/include) that doesn't seem
to work out, currently, and out of the box. Whatever. You get the idea..



More information about the busybox mailing list