[PATCH] make top.c even smaller

Rob Landley rob at landley.net
Tue Feb 14 12:31:27 UTC 2006


On Tuesday 14 February 2006 12:35 pm, Vladimir N. Oleynik wrote:
> Bernhard,
>
> >>diff -urpN busybox.fix2/procps/top.c busybox.fix3/procps/top.c
> >>--- busybox.fix2/procps/top.c	Mon Feb 13 15:41:02 2006
> >>+++ busybox.fix3/procps/top.c	Tue Feb 14 12:23:54 2006
> >>@@ -51,13 +51,13 @@ static procps_status_t *top;   /* Hehe *
> >>static int ntop;
> >>
> >>#ifdef CONFIG_FEATURE_USE_TERMIOS
> >
> > can you please s/ifdef[[:space:]]*CONFIG_/if ENABLE_/gc
> > while at it?
>
> What for?

If you convert CONFIG_ to ENABLE_, please convert from #ifdef to if() while 
you're at it.

Converting CONFIG_ to ENABLE_ mechanically has _no_ advantages, and one big 
disadvantage: we can look for symbols that haven't been converted as targets 
to do a proper cleanup later.

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list